Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add preprocessor symbol to enable/disable Xbyak JIT in core #26712

Merged

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Sep 20, 2024

Details:

  • When OV built with defined symbol OS_CHROMEOS (defined by ChromOS enviroment or user) the Xbyak JIT code will be disabled
  • Temporary use standard implementation instead Xbyak code to enable use OpenVINO on ChromOS.
  • Optimized version using intrinsic code in next PR.

Tickets:

- JIT should be disabled on ChromOS if build defines OS_CHROMEOS
@praasz praasz added this to the 2024.5 milestone Sep 20, 2024
@praasz praasz requested a review from a team as a code owner September 20, 2024 10:55
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Sep 20, 2024
@praasz
Copy link
Contributor Author

praasz commented Sep 20, 2024

@ilya-lavrenov
I'm not 100% sure about symbol OS_CHROMOS if it will be added automatically when build on ChromOS environment.
I'd like avoid add compilation defines by user, please suggest if there is any better option.

@ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov I'm not 100% sure about symbol OS_CHROMOS if it will be added automatically when build on ChromOS environment. I'd like avoid add compilation defines by user, please suggest if there is any better option.

I found the same macro.

@praasz praasz added this pull request to the merge queue Sep 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2024
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Sep 21, 2024
Merged via the queue into openvinotoolkit:master with commit 5033754 Sep 21, 2024
152 checks passed
@praasz praasz deleted the disable-xbyak-in-core-for-chomeos branch October 29, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants