Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[]NPU] Update adapter and backend to use new level zero ext table #27095

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

XinWangIntel
Copy link
Contributor

@XinWangIntel XinWangIntel commented Oct 17, 2024

Details:

  • use ze_graph_dditable_ext_t to replace local ze_graph_dditable_ext_last_t
  • use ze_graph_ext_version_t as template parameter instead of ze_graph_dditable_ext_1_x
  • update commit of level-zero-ext to use one ddi table

Plugin with current driver and driver released later, will use ze_graph_dditable_ext_t and ZE_extension_graph, the version is ZE_GRAPH_EXT_VERSION_CURRENT inside current level-zero-ext commit, 1.8 now

Plugin with old driver, will use ze_graph_dditable_ext_t to reinterpret old ddi table, use largest version supported by driver, , backend work on ze_graph_ext_version_t, compiler will work based on ze_graph_ext_version_t. Fpr example, largest ext version supported by driver is 1.7. plugin will use 1.7.

Tickets:

  • 155313

@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label Oct 17, 2024
@XinWangIntel XinWangIntel force-pushed the ext_table_unified branch 4 times, most recently from cdde2ea to fad034e Compare October 24, 2024 02:56
@XinWangIntel
Copy link
Contributor Author

build_jenkins

@XinWangIntel XinWangIntel changed the title Update adapter and backend to use new level zero ext API []NPU] Update adapter and backend to use new level zero ext API Oct 24, 2024
@XinWangIntel XinWangIntel changed the title []NPU] Update adapter and backend to use new level zero ext API []NPU] Update adapter and backend to use new level zero ext table Oct 25, 2024
@XinWangIntel XinWangIntel marked this pull request as ready for review October 25, 2024 02:36
@XinWangIntel XinWangIntel requested review from a team as code owners October 25, 2024 02:36
@@ -41,46 +41,46 @@ LevelZeroCompilerAdapter::LevelZeroCompilerAdapter(std::shared_ptr<IEngineBacken

switch (graphExtVersion) {
case ZE_GRAPH_EXT_VERSION_1_3:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Graph Extension 1.9? The plan is that driver pushes the change with 1.9 and drop the previous one from Driver extension properties list. It means that 1.8 is not expose any longer by driver and 1.9 is available together with 1.2 up to 1.7 graph extensions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change is not available in the graph-ext version we use in this PR. We agreed to leave that for another PR, where we would also fix the total_mem_size property.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation

@XinWangIntel XinWangIntel force-pushed the ext_table_unified branch 2 times, most recently from 9b9af66 to a74d1ec Compare October 28, 2024 03:37
@PatrikStepan PatrikStepan added this pull request to the merge queue Oct 28, 2024
@PatrikStepan PatrikStepan removed this pull request from the merge queue due to a manual request Oct 28, 2024
@PatrikStepan PatrikStepan added this pull request to the merge queue Oct 28, 2024
Merged via the queue into openvinotoolkit:master with commit 8371289 Oct 28, 2024
139 checks passed
CuriousPanCake pushed a commit to CuriousPanCake/openvino that referenced this pull request Nov 6, 2024
…envinotoolkit#27095)

### Details:
- *use ze_graph_dditable_ext_t to replace local
ze_graph_dditable_ext_last_t*
- *use ze_graph_ext_version_t as template parameter instead of
ze_graph_dditable_ext_1_x*
 - *update commit of level-zero-ext to use one ddi table*

Plugin with current driver and driver released later, will use
ze_graph_dditable_ext_t and ZE_extension_graph, the version is
ZE_GRAPH_EXT_VERSION_CURRENT inside current level-zero-ext commit, 1.8
now

Plugin with old driver, will use ze_graph_dditable_ext_t to reinterpret
old ddi table, use largest version supported by driver, , backend work
on ze_graph_ext_version_t, compiler will work based on
ze_graph_ext_version_t. Fpr example, largest ext version supported by
driver is 1.7. plugin will use 1.7.

### Tickets:
 - *155313*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: NPU OpenVINO NPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants