Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU][TESTS] Fix weightless caching tests #27163

Conversation

tkrupa-intel
Copy link
Contributor

Currently the tests have weightless caching enabled, but the models tested contain no constants eligible for weightless caching. This fixes the situation.

To elaborate - all the models have f32 dtype constants by default. In these particular models all of the constants which would otherwise be eligible for weightless caching undergo some precision transformation which invalidates this eligibilty. The PR changes the dtype of the constants to prevent that and deletes the models which contain no constants eligible for weightless caching even after the dtype change.

@tkrupa-intel tkrupa-intel requested review from a team as code owners October 21, 2024 14:25
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Oct 21, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalIntelPR External contributor from Intel label Oct 21, 2024
@p-durandin
Copy link
Contributor

build_jenkins

Copy link
Contributor

@e-ddykim e-ddykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments:
The root cause is that the default inference precision of GPU is f16.
You can set the inference precision as below:
ov::AnyMap config = { ov::hint::inference_precision(ov::element::f32), ... };
Looks good to me

@p-durandin
Copy link
Contributor

to be rebased after #27171 merge

@p-durandin p-durandin added this pull request to the merge queue Oct 24, 2024
Merged via the queue into openvinotoolkit:master with commit 17f1601 Oct 24, 2024
143 of 145 checks passed
@tkrupa-intel tkrupa-intel deleted the private/tkrupa/fix_weightless_caching_tests branch October 24, 2024 14:58
CuriousPanCake pushed a commit to CuriousPanCake/openvino that referenced this pull request Nov 6, 2024
Currently the tests have weightless caching enabled, but the models
tested contain no constants eligible for weightless caching. This fixes
the situation.

To elaborate - all the models have f32 dtype constants by default. In
these particular models all of the constants which would otherwise be
eligible for weightless caching undergo some precision transformation
which invalidates this eligibilty. The PR changes the dtype of the
constants to prevent that and deletes the models which contain no
constants eligible for weightless caching even after the dtype change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin ExternalIntelPR External contributor from Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants