Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WHEEL] Toml build #27227

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

[WHEEL] Toml build #27227

wants to merge 28 commits into from
+3,008 −93

Conversation

mryzhov
Copy link
Contributor

@mryzhov mryzhov commented Oct 24, 2024

Details:

  • Switched python packaging to pyproject.toml
  • ...

Tickets:

  • ticket-id

@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: Python API OpenVINO Python bindings category: dependency_changes Pull requests that update a dependency file category: packaging OpenVINO packaging / distribution no-match-files labels Oct 24, 2024
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Oct 24, 2024
@mryzhov mryzhov mentioned this pull request Nov 4, 2024
Closed
akuporos
akuporos reviewed Nov 4, 2024
View reviewed changes
src/bindings/python/pyproject.toml
@@ -1,3 +1,45 @@
[tool.black]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please also keep these deleted lines

akuporos
akuporos reviewed Nov 4, 2024
View reviewed changes
src/bindings/python/pyproject.toml
[tool.black]
line-length = 160
include = '\.pyi?$'
[project]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't pyproject.toml placed to the root of the repo to cover also tools/benchmark_app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is discussible, I thought about that too, but at this case we would need to put in the root setup.py too until we drop it at all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree about moving to the root.

@p-wysocki p-wysocki mentioned this pull request Nov 6, 2024
Merged
@github-actions github-actions bot added the category: tools OpenVINO C++ / Python tools label Nov 14, 2024
mryzhov
mryzhov commented Nov 15, 2024
View reviewed changes
src/bindings/python/setup.py Outdated Show resolved Hide resolved
mryzhov
mryzhov commented Nov 15, 2024
View reviewed changes
src/bindings/python/setup.py Outdated Show resolved Hide resolved
mryzhov
mryzhov commented Nov 15, 2024
View reviewed changes
src/bindings/python/setup.py Outdated Show resolved Hide resolved
mryzhov
mryzhov commented Nov 15, 2024
View reviewed changes
src/bindings/python/setup.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuporos akuporos akuporos left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: dependency_changes Pull requests that update a dependency file category: packaging OpenVINO packaging / distribution category: Python API OpenVINO Python bindings category: tools OpenVINO C++ / Python tools github_actions Pull requests that update GitHub Actions code no-match-files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mryzhov @ilya-lavrenov @akuporos