[Snippets] Fixed LoopManager::update_loop_ports #27300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
requested review from
IvanNovoselov and
v-Golubev
and removed request for
a team and
IvanNovoselov
a-sidorova
force-pushed
the
fix/snippets/loop_port_update
branch
2 times, most recently
from
83e593e
to
64ccda1
Compare
2 tasks
src/common/snippets/src/lowered/pass/validate_unified_loops.cpp
Outdated
Show resolved
Hide resolved
a-sidorova
force-pushed
the
fix/snippets/loop_port_update
branch
from
64ccda1
to
0fac67d
Compare
IvanNovoselov
approved these changes
Nov 1, 2024
v-Golubev
approved these changes
Nov 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
### Details: - *Added memory inplace support for Buffer with different precision (it's supported only when output Buffer has data size not more than input Buffer) - it's needed for BF16 and INT8 MHA* - *Added memory inplace support for dynamic Buffers with the marking pass "MarkInvariantShapePath"* ### Tickets: - *154732, 150148* ### Prerequisites: - [x] #27169 - [x] #27300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
LoopPortis expression port connected to another expression port which is not in the same Loop. It's like entry (of exit) point of the Loop. It means that some expression port cannot be port of the Loop if all consumers (or sources) are from the same Loop. However, the methodLoopManager::update_loop_portssometimes creates these situation. This PR fixes this method. The screenshot below describes this situation: red loop is inner loop and blue loops is outer loop. However, some of output ports of this Loop is inside (green question sign) - invalid situation which is fixed by these changes.init_is_incrementedwhich handle invalid case byis_incremented=false.Tickets: