Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opset1::Reshape] Deduce symbol relation based on op spec #27399

Merged
merged 8 commits into from
Nov 11, 2024
Merged

[opset1::Reshape] Deduce symbol relation based on op spec #27399

merged 8 commits into from
Nov 11, 2024

Conversation

jane-intel
Copy link
Contributor

@jane-intel jane-intel commented Nov 5, 2024 •
edited
Loading

Details:

  • Number of elements in the tensor doesn't change after Reshape operation, so we can deduce symbol equality rules
[A, B, 768]
  Reshape
[A, C, 12, 64]

From this Reshape operation we can deduce that B == C.

image

@jane-intel
[opset1::Reshape] Deduce symbol relation based on op spec
2282114 
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
@jane-intel jane-intel requested a review from a team as a code owner November 5, 2024 08:21
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Nov 5, 2024
@jane-intel
Avoid deducing symbols in case the tensor has zero dimensions in shape
9009e01 
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
@jane-intel
Merge remote-tracking branch 'upstream/master' into reshape_symbol_de…
9781315 
…ducing

Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
@jane-intel
Build fix
817f96e 
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
@jane-intel
CPU reshape shape inference: case when special zero copies actual zero
ddb0537 
Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
@jane-intel
Merge remote-tracking branch 'upstream/master' into reshape_symbol_de…
47109a5 
…ducing

Signed-off-by: Evgeniia Nugmanova <evgeniia.nugmanova@intel.com>
@jane-intel jane-intel requested review from a team as code owners November 8, 2024 08:28
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Nov 8, 2024
olpipi
olpipi approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@olpipi olpipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jane-intel jane-intel added this pull request to the merge queue Nov 11, 2024
Merged via the queue into openvinotoolkit:master with commit 539a2ac Nov 11, 2024
166 checks passed
@jane-intel jane-intel deleted the reshape_symbol_deducing branch November 11, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olpipi olpipi olpipi approved these changes

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jane-intel @olpipi