Skip to content

Conversation

@davidsnam-intel
Copy link
Contributor

Details:

  • ROIAlign involves calculations such as interpolation, pooling, and clamping, so for small number, it can introduce more error than other ops.
  • Therefore, it needs to relax threshold for GPU device to avoid false-positive results.
  • For reference, TensorFlow sets for atol to 1e-5 for bilinear resizing test.

Tickets:

  • 142900

@davidsnam-intel davidsnam-intel requested review from a team as code owners October 27, 2025 04:31
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Oct 27, 2025
@e-ddykim
Copy link
Contributor

Please move all your changes into gpu.

@ababushk
Copy link
Contributor

ababushk commented Nov 3, 2025

@e-ddykim did I understand correctly you want the seed to be set only for GPU plugin tests? If so, why is it a bad idea to use a pre-defined seed for all functional tests?

@e-ddykim
Copy link
Contributor

e-ddykim commented Nov 3, 2025

@e-ddykim did I understand correctly you want the seed to be set only for GPU plugin tests? If so, why is it a bad idea to use a pre-defined seed for all functional tests?

Hi @ababushk, I don't think it's a bad idea but just want for this change not to affect other test cases.

@davidsnam-intel davidsnam-intel force-pushed the david/fix-roialign-testcase branch from c5a17cd to 7308b2d Compare November 3, 2025 16:32
@davidsnam-intel davidsnam-intel requested review from a team as code owners November 3, 2025 16:32
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Nov 3, 2025
@ababushk ababushk enabled auto-merge November 3, 2025 17:30
@ababushk ababushk added this pull request to the merge queue Nov 3, 2025
Merged via the queue into openvinotoolkit:master with commit a659e8c Nov 3, 2025
203 of 204 checks passed
@praasz praasz added this to the 2025.4 milestone Nov 5, 2025
IamRam3 pushed a commit to IamRam3/openvino that referenced this pull request Nov 6, 2025
### Details:
- ROIAlign involves calculations such as interpolation, pooling, and
clamping, so for small number, it can introduce more error than other
ops.
- Therefore, it needs to relax threshold for GPU device to avoid
false-positive results.
- For reference, `TensorFlow` sets for `atol` to `1e-5` for bilinear
resizing test.

### Tickets:
 - 142900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants