[onnx] Fix create ONNX DFT op for scalar signal size #32637
Conversation
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
|
|
||
| bool dft_length_provided = !ov::op::util::is_null(length); | ||
| const bool dft_length_provided = !ov::op::util::is_null(length); | ||
| const auto unsqueeze_axis = v0::Constant::create(ov::element::i64, {}, {-1}); |
There was a problem hiding this comment.
| const auto unsqueeze_axis = v0::Constant::create(ov::element::i64, {}, {-1}); | |
| const auto unsqueeze_axis = v0::Constant::create(ov::element::i32, {}, {0}); |
i32 is quite enough. Also, let use define axis, not -1
There was a problem hiding this comment.
Id like to same const in two cases and originally this const was i64.
But if this is ok to use i32 in both places I can change it
There was a problem hiding this comment.
Yes, i32 works and we waste less memory.
| const auto unsqueeze_axis = v0::Constant::create(ov::element::i64, {}, {-1}); | ||
| const auto& signal_size = [&] { | ||
| if (dft_length_provided) { | ||
| if (const auto& rank = length.get_partial_shape().rank(); rank.get_max_length() == 0) { |
There was a problem hiding this comment.
here you also need to check rank().is_static()
I propose to use Reshape operation with shape=[1] and apply this operation always without check. Or at least, apply Reshape when rank is dynamic.
There was a problem hiding this comment.
There is no need to check static, max length is 0 for scalar.
But in case if input is 2-D, reshape will change it to 1-D, but it should be still an error condition.
2 participants
Details:
dft_lengthas scalar input which is not compatible with OV FFT operators (Must be 1-D). In case of scalar input unsqueeze this input to 1-D.Tickets: