[CPU][Android] Normalize late Convert in PostSnippets and fix FC pass namespace #32640
+94
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… namespace\n\n- Add NormalizeConvertPreLower (Android-only) and register in PostSnippets\n- Use ov::pass::ConvertFullyConnectedToFullyConnectedCompressed to avoid ambiguous namespace\n- No other changes outside intel_cpu; no alias shim
allnes
added
platform: android
v-Golubev
reviewed
Nov 10, 2025
| @@ -0,0 +1,65 @@ | |||
| // Copyright (C) 2025 Intel Corporation | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright (C) 2025 Intel Corporation | |
| // Copyright (C) 2018-2025 Intel Corporation |
| @@ -0,0 +1,23 @@ | |||
| // Copyright (C) 2025 Intel Corporation | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright (C) 2025 Intel Corporation | |
| // Copyright (C) 2018-2025 Intel Corporation |
Comment on lines
+12
to
+14
| // CPU-side pass: for every ov::snippets::op::Subgraph, replace any remaining | ||
| // ov::op::v0::Convert / opset1::Convert inside subgraph body with | ||
| // ov::snippets::op::ConvertTruncation right before lowering in CPU pipeline. |
Contributor
There was a problem hiding this comment.
Could you please specify more context in the pass description (That we workaround android specific problem, its details etc.)?
Comment on lines
+22
to
+23
| auto m_v0 = ov::pass::pattern::wrap_type<ov::op::v0::Convert>(); | ||
| auto m_v1 = ov::pass::pattern::wrap_type<ov::opset1::Convert>(); |
Contributor
There was a problem hiding this comment.
Could you please try this option?
Suggested change
| auto m_v0 = ov::pass::pattern::wrap_type<ov::op::v0::Convert>(); | |
| auto m_v1 = ov::pass::pattern::wrap_type<ov::opset1::Convert>(); | |
| auto convert_m = ov::pass::pattern::wrap_type<ov::op::v0::Convert, ov::opset1::Convert>(); |
If it works for android, I'd prefer leaving it since it is shorter
Comment on lines
+28
to
+35
| ov::element::Type dst; | ||
| if (auto c0 = std::dynamic_pointer_cast<ov::op::v0::Convert>(cv)) { | ||
| dst = c0->get_destination_type(); | ||
| } else if (auto c1 = std::dynamic_pointer_cast<ov::opset1::Convert>(cv)) { | ||
| dst = c1->get_destination_type(); | ||
| } else { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
dst can be always get as cv->get_output_element_type(0), we can avoid the casting here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NormalizeConvertPreLower (Android-only) and register in PostSnippets
Use ov::pass::ConvertFullyConnectedToFullyConnectedCompressed to avoid ambiguous namespace