Skip to content

[core] Change MapHolder mmap flag to MAP_SHARED #32999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[core] Change MapHolder mmap flag to MAP_SHARED #32999

wants to merge 1 commit into from
+1 −1

Conversation

@praasz
Copy link
Contributor

@praasz praasz commented Nov 24, 2025

Details:

  • MAP_PRIVATE to MAP_SHARED, to avoid copy-on-write scenario, file will be still read-only.
  • To be compatible what is done on Windows by ::MapViewOfFile

Tickets:

@praasz
Change MapHolder mmap flag to MAP_SHARED
c647ccb 
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
@praasz praasz requested a review from a team as a code owner November 24, 2025 07:17
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Nov 24, 2025
olpipi
olpipi reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@olpipi olpipi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have copy-on-write on Windows as well. To change it, we should change flags in all: CreateFileW, CreateFileMapping, MapViewOfFile

@jwludzik
Copy link

jwludzik commented Nov 27, 2025

We still have copy-on-write on Windows as well. To change it, we should change flags in all: CreateFileW, CreateFileMapping, MapViewOfFile

I do not see anywhere FILE_MAP_COPY set in Windows. Can you help me to understand where the copy-on-write is used in OpenVINO code for Windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olpipi olpipi olpipi left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@olpipi olpipi

Labels

category: Core OpenVINO Core (aka ngraph)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@praasz @jwludzik @olpipi