Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Extend Reduce node to support blocked layouts nC[d]hw8/16C and implement jitted Reduce node #580

Merged
merged 1 commit into from
Sep 7, 2020
Merged

[CPU] Extend Reduce node to support blocked layouts nC[d]hw8/16C and implement jitted Reduce node #580

merged 1 commit into from
Sep 7, 2020

Conversation

xuchen-intel
Copy link
Contributor

@xuchen-intel xuchen-intel commented May 26, 2020 •
edited
Loading

  • [CPU] Extend Reduce node to support blocked layouts nC[d]hw8/16C
  • [CPU] Implement jitted Reduce node
  • [CPU] Extend Reduce node to support data type I8

@xuchen-intel xuchen-intel requested review from a team May 26, 2020 07:30
@ilya-lavrenov ilya-lavrenov added the category: CPU OpenVINO CPU plugin label May 26, 2020
@ilya-lavrenov
Copy link
Contributor

@dmitry-gorokhov is to OK to merge 10 primitives into 1? In this case we cannot conditionally compile some of them..

@xuchen-intel
Copy link
Contributor Author

@dmitry-gorokhov Hi Dmitry, could you please review?

@dmitry-gorokhov dmitry-gorokhov added this to the 2021.1 milestone Jun 13, 2020
dmitry-gorokhov
dmitry-gorokhov requested changes Jun 22, 2020
View reviewed changes
inference-engine/src/mkldnn_plugin/nodes/mkldnn_reduce_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_reduce_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_reduce_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_reduce_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_reduce_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_reduce_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_reduce_node.h Outdated Show resolved Hide resolved
inference-engine/tests_deprecated/unit/engines/mkldnn/graph/layers/extensions/reduce_tests.cpp Outdated Show resolved Hide resolved
@xuchen-intel xuchen-intel requested a review from a team July 7, 2020 07:27
@xuchen-intel xuchen-intel force-pushed the feature/reduce_node branch 6 times, most recently from 5fb1cea to e254cdc Compare July 10, 2020 01:25
@dmitry-gorokhov
Copy link
Contributor

@xuchen-intel Please rebase you branch on latest master

@xuchen-intel xuchen-intel force-pushed the feature/reduce_node branch 7 times, most recently from 38b1c06 to 416838b Compare July 24, 2020 04:28
@openvino-pushbot openvino-pushbot added the category: IE Tests OpenVINO Test: plugins and common label Aug 11, 2020
@xuchen-intel xuchen-intel force-pushed the feature/reduce_node branch 2 times, most recently from 49046e6 to f4c186b Compare August 12, 2020 05:08
@xuchen-intel xuchen-intel force-pushed the feature/reduce_node branch 5 times, most recently from d75b6ef to a2fa497 Compare September 7, 2020 05:49
@xuchen-intel
* [CPU] Extend Reduce node to support blocked layouts nC[d]hw8/16C
1936932 
* [CPU] Implement jitted Reduce node

* [CPU] Extend Reduce node to support data type I8
@dmitry-gorokhov dmitry-gorokhov merged commit cba0892 into openvinotoolkit:master Sep 7, 2020
@xuchen-intel xuchen-intel mentioned this pull request May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenhu-wang chenhu-wang chenhu-wang left review comments

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees
No one assigned
Labels
category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
2021.1
Development

Successfully merging this pull request may close these issues.
5 participants
@xuchen-intel @ilya-lavrenov @dmitry-gorokhov @chenhu-wang @openvino-pushbot