Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTE] Update OpenVINO to 2022.3 release #1393

Merged
merged 13 commits into from
Jan 10, 2023
Merged

[OTE] Update OpenVINO to 2022.3 release #1393

merged 13 commits into from
Jan 10, 2023

Conversation

sovrasov
Copy link
Collaborator

@sovrasov sovrasov commented Nov 25, 2022

@sovrasov sovrasov requested a review from a team as a code owner November 25, 2022 14:36
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM API Any changes in OTX API ALGO Any changes in OTX Algo Tasks implementation labels Nov 25, 2022
@sovrasov
Copy link
Collaborator Author

run ote-test

@sovrasov
Copy link
Collaborator Author

run ote-test

1 similar comment
@sovrasov
Copy link
Collaborator Author

run ote-test

@sovrasov sovrasov changed the title Update OpenVINO to 2022.3 dev preview [OTE] Update OpenVINO to 2022.3 release Dec 21, 2022
@sovrasov
Copy link
Collaborator Author

run ote-test

1 similar comment
@sovrasov
Copy link
Collaborator Author

run ote-test

@sovrasov
Copy link
Collaborator Author

run ote-test

@sovrasov
Copy link
Collaborator Author

sovrasov commented Jan 3, 2023

run ote-test

4 similar comments
@sovrasov
Copy link
Collaborator Author

sovrasov commented Jan 4, 2023

run ote-test

@sovrasov
Copy link
Collaborator Author

sovrasov commented Jan 4, 2023

run ote-test

@sovrasov
Copy link
Collaborator Author

sovrasov commented Jan 4, 2023

run ote-test

@sovrasov
Copy link
Collaborator Author

sovrasov commented Jan 5, 2023

run ote-test

@sovrasov
Copy link
Collaborator Author

sovrasov commented Jan 5, 2023

run ote-test

@sovrasov
Copy link
Collaborator Author

sovrasov commented Jan 9, 2023

run ote-test

@sovrasov
Copy link
Collaborator Author

sovrasov commented Jan 9, 2023

@sovrasov sovrasov requested a review from goodsong81 January 10, 2023 07:37
Copy link

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
image

@goodsong81 goodsong81 requested a review from sungmanc January 10, 2023 09:26
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodsong81 goodsong81 merged commit 595584b into develop Jan 10, 2023
@goodsong81 goodsong81 deleted the vs/ov_update branch January 10, 2023 10:08
@samet-akcay
Copy link
Collaborator

@sovrasov, @goodsong81, do you guys know why we need to install both openvino and openvino-dev? Is there any specific motivation to have this installation? Can't we just do pip install openvino["dev"] that would install the dev package as well as the base openvino ? Or why openvino-dev does not install the base openvino? Any ideas, thoughts?

@sovrasov
Copy link
Collaborator Author

Hi Samet, you're right, we can omit openvino if we have openvino-dev. openvino package version is always presented here for clarity and historically we always added it implicitly. Perhaps, we may change that in otx.

@samet-akcay
Copy link
Collaborator

Vlad, thanks for the clarification!

openvino package version is always presented here for clarity and historically we always added it implicitly.

To be honest, it caused more confusion to me than clarity. I would agree to only keep openvino-dev if it also installs the base openvino. This way, we would get rid of one more dependency, wouldn't need to maintain version numbers etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants