-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE][Anomaly] Add region-based anomaly detection model #1684
Conversation
@djdameln As we've passed the feature freeze for OTX1.0, please don't merge this to develop branch until the code freeze and release branch creation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Two minor comments but the rest looks good
@@ -0,0 +1,95 @@ | |||
"""Configurable parameters for Padim anomaly Detection task.""" | |||
|
|||
# Copyright (C) 2021 Intel Corporation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update this
operator: AND | ||
rules: [] | ||
type: UI_RULES | ||
visible_in_ui: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is autogenerated I think we have to set visible_in_ui
to false and editable
to false as well. These are based on this comment #1230 (comment). Not sure if this has been addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to prevent merge by mistake ;)
Codecov ReportBase: 62.49% // Head: 78.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1684 +/- ##
============================================
+ Coverage 62.49% 78.86% +16.37%
============================================
Files 506 473 -33
Lines 31086 32890 +1804
============================================
+ Hits 19426 25939 +6513
+ Misses 11660 6951 -4709
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
closed for cleaning up stale branch |
This PR adds the task implementation for the Region-based anomaly detection model.