Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][Anomaly] Add region-based anomaly detection model #1684

Closed
wants to merge 4 commits into from

Conversation

djdameln
Copy link
Collaborator

This PR adds the task implementation for the Region-based anomaly detection model.

@djdameln djdameln requested a review from a team as a code owner February 13, 2023 16:07
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Feb 13, 2023
@djdameln djdameln requested a review from samet-akcay February 13, 2023 16:07
@goodsong81
Copy link

@djdameln As we've passed the feature freeze for OTX1.0, please don't merge this to develop branch until the code freeze and release branch creation.

ashwinvaidya17
ashwinvaidya17 previously approved these changes Feb 14, 2023
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two minor comments but the rest looks good

@@ -0,0 +1,95 @@
"""Configurable parameters for Padim anomaly Detection task."""

# Copyright (C) 2021 Intel Corporation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this

operator: AND
rules: []
type: UI_RULES
visible_in_ui: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is autogenerated I think we have to set visible_in_ui to false and editable to false as well. These are based on this comment #1230 (comment). Not sure if this has been addressed.

@goodsong81 goodsong81 changed the title [Anomaly] Add region-based anomaly detection model [FEATURE][Anomaly] Add region-based anomaly detection model Feb 17, 2023
@goodsong81 goodsong81 added this to the 1.1.0 milestone Feb 17, 2023
Copy link

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to prevent merge by mistake ;)

@codecov-commenter
Copy link

Codecov Report

Base: 62.49% // Head: 78.86% // Increases project coverage by +16.37% 🎉

Coverage data is based on head (0853387) compared to base (5015ba2).
Patch coverage: 7.69% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1684       +/-   ##
============================================
+ Coverage    62.49%   78.86%   +16.37%     
============================================
  Files          506      473       -33     
  Lines        31086    32890     +1804     
============================================
+ Hits         19426    25939     +6513     
+ Misses       11660     6951     -4709     
Impacted Files Coverage Δ
...ms/anomaly/configs/detection/rkde/configuration.py 0.00% <0.00%> (ø)
...maly/configs/detection/rkde/configuration_enums.py 0.00% <0.00%> (ø)
.../algorithms/anomaly/adapters/anomalib/data/data.py 97.05% <100.00%> (ø)
otx/algorithms/anomaly/tasks/train.py 86.66% <100.00%> (ø)
otx/api/utils/vis_utils.py 44.44% <0.00%> (-45.56%) ⬇️
...dapters/mmcv/utils/_builder_build_data_parallel.py 65.51% <0.00%> (-7.56%) ⬇️
.../core/data/adapter/segmentation_dataset_adapter.py 93.96% <0.00%> (-6.04%) ⬇️
otx/algorithms/detection/tasks/openvino.py 73.94% <0.00%> (-4.11%) ⬇️
otx/algorithms/classification/tasks/openvino.py 86.66% <0.00%> (-2.59%) ⬇️
otx/api/utils/shape_factory.py 93.84% <0.00%> (-1.54%) ⬇️
... and 344 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@goodsong81 goodsong81 modified the milestones: 1.1.0, 1.2.0 Mar 17, 2023
@yunchu
Copy link
Contributor

yunchu commented Oct 19, 2023

closed for cleaning up stale branch

@yunchu yunchu closed this Oct 19, 2023
@yunchu yunchu deleted the da/region-based-anomaly-detection branch October 19, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants