-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCE] Bring mmdeploy to action recognition model export & Test optimization of action tasks #1848
Conversation
@cih9088 Could you review overall structure for linking between action tasks and mmdeploy framework, and deployment.py for each action models? Since I'm not familiar with mmdeploy, your review would be helpful. Minor comment will be fixed in this PR and large suggestion such as changing overall architecture will be reflected in another PR after merging this PR |
@jaegukhyun please set the milestone for this PR. I guess it would be included to the next release (v1.1.0), right? |
Thank's for the remark, I set it as 1.1.0 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1848 +/- ##
===========================================
- Coverage 80.54% 80.52% -0.03%
===========================================
Files 481 483 +2
Lines 32998 32943 -55
===========================================
- Hits 26579 26527 -52
+ Misses 6419 6416 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed that task structure is pretty different from cls/det/seg. Would cls/det/seg be refactored in a way where action implemented task?
Additionally, otxdeploy
requirement should be added into requirements/action.txt
otx/algorithms/action/adapters/mmaction/models/detectors/fast_rcnn.py
Outdated
Show resolved
Hide resolved
otx/algorithms/action/configs/classification/base/base_classification_dynamic.py
Outdated
Show resolved
Hide resolved
otx/algorithms/action/configs/detection/base/base_detection_dynamic.py
Outdated
Show resolved
Hide resolved
otx/algorithms/action/configs/detection/base/base_detection_dynamic.py
Outdated
Show resolved
Hide resolved
otx/algorithms/action/configs/classification/base/base_classification_dynamic.py
Outdated
Show resolved
Hide resolved
otx/algorithms/action/adapters/mmaction/models/detectors/fast_rcnn.py
Outdated
Show resolved
Hide resolved
otx/algorithms/action/adapters/mmaction/models/detectors/fast_rcnn.py
Outdated
Show resolved
Hide resolved
otx/algorithms/action/adapters/mmaction/models/detectors/fast_rcnn.py
Outdated
Show resolved
Hide resolved
@cih9088 Thank you for your detailed review, I reflected almost of your review. Currently action task do not use mpa side code, therefore I create own export codes. After refactoring mpa codes, I'll make another PR for unifying exporting process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for hard work!
…_extensions into jg/action-mmdeploy
This PR includes
Why this should be changed
Unlike other algorithms in otx, action tasks use manual export procedure, not mmdeploy. For unity and convenience this PR brings mmdeploy as a framework to export action algo models.
And also, action tasks cli test train models for 2 epochs, so it requires more time than other algorithms. Therefore this PR reduces it to 1
Changes
Known Issues
In pytorch 1.13 3d pooling do not work in openvino ==> Soloved by temporal manual method
In pytorch 1.13 Two stage openvino models return empty inference result ==> Will be solved in CVS104657
Action task do not support dump_features(feature vector, saliency map) ==> Will be treated in another PR
Bring mmdeploy to mmaction's model
Test optimization for action tasks
Change unit tests for this PR