Generalized OTXMoViNet state dict hooks to work within other modules #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JihwanEom If there is no errors for training and eval for MoViNet in this branch. How about merging this before refactoring? |
Sounds good for me, but that will cause very huge pre-commit issues :( is it okay for you? |
|
It's heading to your MoViNet branch, and your MoViNet branch should solve any other issue to merge to develop |
I was super beginner, wow I'll merge this. Thanks @nikita-savelyevv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generalized OTXMoViNet state dict hooks to work within other modules.
Reason
NNCF wraps a module to be compressed inside the
NNCFNetworkmodule. Butstate_dicthooks implemented forOTXMoViNetassume that it is the highest module in the hierarchy. Thus they don't work as expected when wrapped insideNNCFNetworkmodule.