Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Enable VOC dataset in OTX #1862

Merged
merged 5 commits into from
Mar 8, 2023
Merged

[FIX] Enable VOC dataset in OTX #1862

merged 5 commits into from
Mar 8, 2023

Conversation

supersoob
Copy link
Contributor

Issue

  • VOC dataset is not properly supported in OTX
  • Cannot exactly detect the train/val subset specified in VOC dataset

Root Cause

  • When get_train_dataset from datumaro format, it checks key includes any "train" str. Thus, it first bring the subset dataset named "trainval", not "train"
  • When get_val_dataset from datumaro format, it checks key includes any "val" str. Thus, it first bring the subset dataset named "trainval", not "val"
  • Only if masks annotation exists, dataset item is valid. but it included the shape with no annotation.

Solution

  • Resolved by checking whole words, "train" and "val" first

@supersoob supersoob requested a review from sungmanc March 7, 2023 07:55
@supersoob supersoob requested a review from a team as a code owner March 7, 2023 07:55
sungmanc
sungmanc previously approved these changes Mar 7, 2023
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@kprokofi
Copy link
Collaborator

kprokofi commented Mar 7, 2023

Will it also fix COCO dataset bug, when it uses the same "trainval" instead of "train" and "val" (for instance segmentation)?

@sungmanc
Copy link
Contributor

sungmanc commented Mar 7, 2023

Will it also fix COCO dataset bug, when it uses the same "trainval" instead of "train" and "val" (for instance segmentation)?

Yes, if user prepare "instances_trainval.json", then we can avoid including this annotation to train annotation.

kprokofi
kprokofi previously approved these changes Mar 7, 2023
@kprokofi kprokofi enabled auto-merge (squash) March 7, 2023 09:17
jaegukhyun
jaegukhyun previously approved these changes Mar 7, 2023
@supersoob supersoob dismissed stale reviews from jaegukhyun, kprokofi, and sungmanc via 3b39abf March 8, 2023 01:52
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (872f119) 80.55% compared to head (3b39abf) 80.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1862      +/-   ##
===========================================
- Coverage    80.55%   80.53%   -0.03%     
===========================================
  Files          481      481              
  Lines        32986    32995       +9     
===========================================
- Hits         26573    26572       -1     
- Misses        6413     6423      +10     
Impacted Files Coverage Δ
.../core/data/adapter/segmentation_dataset_adapter.py 94.01% <100.00%> (+0.05%) ⬆️
otx/core/data/manager/dataset_manager.py 97.18% <100.00%> (-2.82%) ⬇️
...dapters/openvino/model_wrappers/openvino_models.py 74.00% <0.00%> (-3.00%) ⬇️
otx/algorithms/detection/tasks/inference.py 71.16% <0.00%> (-1.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@goodsong81 goodsong81 disabled auto-merge March 8, 2023 05:13
@goodsong81 goodsong81 merged commit 5dbe261 into develop Mar 8, 2023
@goodsong81 goodsong81 deleted the soobee/voc-enable branch March 8, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants