-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DetCon logic & Update SupCon for seg recipes #1958
Refactor DetCon logic & Update SupCon for seg recipes #1958
Conversation
89393e3
to
b4c7ca8
Compare
I changed the title of this PR, we're not using [FIX], [ENHANCE] prefix anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it showed quite improvement for SupCon algorithm. How about adding this changes to CHANGELOG ?
Ah, there is test failure, could you check it? |
@sungmanc @jaegukhyun |
Co-authored-by: Sungman Cho <sungman.cho@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR includes
DetConHead
including detcon loss and predictorThrough these changes, we can expect improved mDice (~+4.96) and reduced training time (~0.68x) compared with base supervised learning.
How to test
tests/unit/algorithms/segmentation/adapters/mmseg/models/heads/test_detcon_head.py
tests/unit/algorithms/segmentation/adapters/mmseg/models/segmentors/test_detcon.py
tests/unit/algorithms/segmentation/adapters/mmseg/models/losses/test_detcon_loss.py
Checklist
License
Feel free to contact the maintainers if that's a concern.