Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hierarchical label in classification task #2149

Merged
merged 4 commits into from
May 15, 2023

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented May 15, 2023

Summary

  • Ticket: CVS-108587

Exploited existing LabelSchema feature, LabelTree for hierarchical label support. A task can use it through self._task_environment.label_schema.label_tree

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@cih9088 cih9088 added the ENHANCE Enhancement of existing features label May 15, 2023
@cih9088 cih9088 added this to the 1.3.0 milestone May 15, 2023
@cih9088 cih9088 requested a review from a team as a code owner May 15, 2023 02:42
@github-actions github-actions bot added DOC Improvements or additions to documentation API Any changes in OTX API labels May 15, 2023
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @sovrasov , could you also take a look this ?

@cih9088 cih9088 merged commit fcd3ecd into openvinotoolkit:develop May 15, 2023
@cih9088 cih9088 deleted the feature/label-tree branch May 15, 2023 06:47
@sovrasov
Copy link
Collaborator

From my side, I'd expect at least unit tests for that functionality, but it's already merged.

@cih9088
Copy link
Contributor Author

cih9088 commented May 15, 2023

From my side, I'd expect at least unit tests for that functionality, but it's already merged.

PR for unit tests: #2152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any changes in OTX API DOC Improvements or additions to documentation ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants