-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adpat timeout value of torch.dist.init_process_group depending on elapsed time #2422
Adpat timeout value of torch.dist.init_process_group depending on elapsed time #2422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the nitpick but could you fix the changelog while resoling the conflict anyway? :)
I have a question, are |
Spawning multi process is executed after preparing dataset. So, When main process initializes first and waits for child process initialization, child process should prepare dataset first before initialization. So if dataset preparation is more than timeout seconds, timeout error is raised. |
Understood, thanks for the kind explanation |
Co-authored-by: Songki Choi <songki.choi@intel.com>
22c1926
to
1bd56ea
Compare
Sorry I add a commit to resolve conflict of CHANGELOG.md. Could you review PR again, @sungmanc @goodsong81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem :)
Summary
When huge dataset is used, more than 30 seconds is used to prepare dataset, which raises an error when training with multi GPU because current
torch.dist.init_process_group
timeout is set as 30.So, I implemented a feature to adapt timeout value if process start time is given.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.