-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Semi-SL Instance Segmentation #2444
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2444 +/- ##
===========================================
+ Coverage 81.18% 81.35% +0.16%
===========================================
Files 516 516
Lines 37610 37686 +76
===========================================
+ Hits 30534 30658 +124
+ Misses 7076 7028 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
src/otx/algorithms/common/adapters/mmcv/hooks/unbiased_teacher_hook.py
Outdated
Show resolved
Hide resolved
src/otx/algorithms/detection/adapters/mmdet/models/detectors/unbiased_teacher.py
Outdated
Show resolved
Hide resolved
src/otx/algorithms/detection/adapters/mmdet/models/losses/cross_focal_loss.py
Outdated
Show resolved
Hide resolved
src/otx/algorithms/detection/configs/base/data/semisl/base_semisl_det_data_pipeline.py
Show resolved
Hide resolved
src/otx/algorithms/detection/configs/base/data/semisl/semisl_is_eff_data_pipeline.py
Show resolved
Hide resolved
src/otx/algorithms/detection/configs/instance_segmentation/resnet50_maskrcnn/template.yaml
Show resolved
Hide resolved
tests/e2e/cli/instance_segmentation/test_instance_segmentation.py
Outdated
Show resolved
Hide resolved
src/otx/algorithms/detection/adapters/mmdet/models/detectors/mean_teacher.py
Show resolved
Hide resolved
Below the pivot table with PoC and comparison with other candidates inside OTX
|
There are mmdet metrics:
|
Could you add a summary for this PR to help to understand the objective and contents of this PR before reviewing? |
I added it in the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort, I left few comments
src/otx/algorithms/detection/configs/base/data/semisl/semisl_is_eff_data_pipeline.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Unbiased Teacher" -> general "Mean Teacher" scheme looks good to me.
Hope this would benefit both of det & iseg.
I've left a few minor change requests & qeustions.
Thank you for the great work!
Summary
This PR includes Semi-SL Instance Segmentation solution based on the Mean Teacher algorithm after conducted PoC .
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.