Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that fp16 key error is raised when training without GPU #2501

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Sep 15, 2023

Summary

Key error is raised when setting configuration in training a model w/o GPU.
It's because trying to delete fp16 in cfg after fp16 is already popped from cfg.
This PR fixes it.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eunwoosh eunwoosh added the FIX defect fix label Sep 15, 2023
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Sep 15, 2023
@eunwoosh eunwoosh changed the title fix bug Fix a bug that fp16 key error is raised when training without GPU Sep 15, 2023
@github-actions github-actions bot added the DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label Sep 15, 2023
@eunwoosh eunwoosh marked this pull request as ready for review September 15, 2023 05:37
@eunwoosh eunwoosh requested a review from a team as a code owner September 15, 2023 05:37
@eunwoosh eunwoosh merged commit 957422f into openvinotoolkit:develop Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM FIX defect fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants