-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Semi-SL for Multi-class Classification (EfficientNet-B0) #3566
Add Semi-SL for Multi-class Classification (EfficientNet-B0) #3566
Conversation
…_extensions into harimkan/semi-sl-pipeline
…_extensions into harimkan/semi-sl-refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3566 +/- ##
===========================================
- Coverage 82.86% 82.51% -0.35%
===========================================
Files 256 258 +2
Lines 25305 25394 +89
===========================================
- Hits 20968 20954 -14
- Misses 4337 4440 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Overall design looks good.
Can we simplify --data.config.unlabeled_subset.data_root CLI command? I prefer shorter, maybe we can create a link to this param and call it as "--unlabeled_data_root" |
Looking at it, the current data-related configs are gathered in data.config. For now, I think we need to think a little more about how to make this a little shorter. Personally, I think it would be better if it goes along with the refactoring of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kim, Sungchul <sungchul.kim@intel.com>
…_extensions into harimkan/semi-sl-refactor
Summary
CVS-141546
For the example above,
--data_root
issupervised/
and
--data.config.unlabeled_subset.data_root
must be specified asunlabeled/
.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.