Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupling mmaction for action classification (MoviNet, X3D) #3582

Merged
merged 24 commits into from
Jun 10, 2024

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Jun 5, 2024

Summary

Performance comparison of movinet and x3d on ucf_kinetics_5percent_small dataset.
The results are averaged over 5 different seeds.

develop test/acc export/acc
movinet 0.513235 0.495588
x3d 0.697059 0.679412
decouple test/acc export/acc
movinet 0.539706 0.532353
x3d 0.695588 0.698529

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added TEST Any changes in tests OTX 2.0 labels Jun 5, 2024
@wonjuleee wonjuleee force-pushed the decoup_action branch 2 times, most recently from 4bca2da to c4f9b71 Compare June 6, 2024 14:11
@wonjuleee wonjuleee changed the title Decoupling mmaction for action classification MoviNet Decoupling mmaction for action classification (MoviNet, X3D) Jun 6, 2024
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM BUILD labels Jun 10, 2024
sungchul2
sungchul2 previously approved these changes Jun 10, 2024
Copy link
Contributor

@sungchul2 sungchul2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your hard work!

yunchu
yunchu previously approved these changes Jun 10, 2024
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work :) I left some comments. Please take a look.

Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add minor comments.

Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for applying my comments :)

@wonjuleee wonjuleee merged commit af03ae0 into openvinotoolkit:develop Jun 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants