Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_from_checkpoint to apply original model's hparams #3607

Merged

Conversation

sungchul2
Copy link
Contributor

Summary

When testing the model with the parameters different from one used during training, they haven't been appropriately applied.
Check infer_reference_info_root in the below example. The default value of infer_reference_info_root is ../.latest/train and I want to update it to another path.
The order is:

  • original model set for test
  • previously created model by load_from_checkpoint(...)
  • updated one by load_from_checkpoint(..., **model.hparams)

image

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungchul2 sungchul2 enabled auto-merge (squash) June 12, 2024 03:48
@sungchul2 sungchul2 merged commit bc9ede3 into openvinotoolkit:develop Jun 12, 2024
13 checks passed
@sungchul2 sungchul2 deleted the fix-load-from-checkpoint branch June 12, 2024 03:59
sungchul2 added a commit to sungchul2/training_extensions that referenced this pull request Oct 23, 2024
sungchul2 added a commit to sungchul2/training_extensions that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants