Fix load_from_checkpoint
to apply original model's hparams
#3607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When testing the model with the parameters different from one used during training, they haven't been appropriately applied.
Check
infer_reference_info_root
in the below example. The default value ofinfer_reference_info_root
is../.latest/train
and I want to update it to another path.The order is:
load_from_checkpoint(...)
load_from_checkpoint(..., **model.hparams)
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.