-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTX D-Fine Detection Algorithm Integration #4142
Merged
sovrasov
merged 95 commits into
openvinotoolkit:develop
from
eugene123tw:eugene/d-fine-poc
Jan 17, 2025
Merged
OTX D-Fine Detection Algorithm Integration #4142
sovrasov
merged 95 commits into
openvinotoolkit:develop
from
eugene123tw:eugene/d-fine-poc
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coverage reporting
…ect model name in converter
…dd min_lr, and remove unused callbacks
Daankrol
previously approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Some very small notes, can be merged if tests are fixed.
…imizer configuration documentation; change reg_scale to float in DFINETransformer.
Daankrol
approved these changes
Jan 17, 2025
sovrasov
reviewed
Jan 17, 2025
sovrasov
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BUILD
DEPENDENCY
Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
DOC
Improvements or additions to documentation
TEST
Any changes in tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OTX D-Fine Detection Algorithm Integration: https://github.com/Peterande/D-FINE
Cross-Reference Comparison
Next phase
How to test
otx train --config src/otx/recipe/detection/dfine_x.yaml --data_root DATA_ROOT
pytest tests/unit/algo/detection/test_dfine.py
Checklist
License
Feel free to contact the maintainers if that's a concern.