Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure target class indices are of type long in loss calculations #4143

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Ensure target class indices are of type long in loss calculations #4143

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea5ead2
Ensure target class indices are of type long in loss calculations
eugene123tw Dec 4, 2024
f5cd1ec
update changelog
eugene123tw Dec 4, 2024
ef32906
Merge branch 'releases/2.2.0' into eugene/fix-detr-dtype-casting
eugene123tw Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/otx/algo/detection/losses/rtdetr_loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def loss_labels_vfl(
src_logits = outputs["pred_logits"]
target_classes_o = torch.cat([t["labels"][J] for t, (_, J) in zip(targets, indices)])
target_classes = torch.full(src_logits.shape[:2], self.num_classes, dtype=torch.int64, device=src_logits.device)
target_classes[idx] = target_classes_o
target_classes[idx] = target_classes_o.long()
target = nn.functional.one_hot(target_classes, num_classes=self.num_classes + 1)[..., :-1]

target_score_o = torch.zeros_like(target_classes, dtype=src_logits.dtype)
Expand Down
2 changes: 1 addition & 1 deletion src/otx/algo/detection/utils/matchers/hungarian_matcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def forward(
out_bbox = outputs["pred_boxes"].flatten(0, 1) # [batch_size * num_queries, 4]

# Also concat the target labels and boxes
tgt_ids = torch.cat([v["labels"] for v in targets])
tgt_ids = torch.cat([v["labels"] for v in targets]).long()
tgt_bbox = torch.cat([v["boxes"] for v in targets])

# Compute the classification cost. Contrary to the loss, we don't use the NLL,
Expand Down
Loading