Skip to content

Commit

Permalink
Remove unnecessary FIXME
Browse files Browse the repository at this point in the history
  • Loading branch information
nyunyunyunyu committed Jan 17, 2025
1 parent 03af15d commit fd19628
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion extensions/native/recursion/src/fri/domain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ where
shift: builder.eval(self.shift * domain_power),
g,
};
// FIXME: here must use `builder.set_value`. `builder.set` will convert `Usize::Const`
// ATTENTION: here must use `builder.set_value`. `builder.set` will convert `Usize::Const`
// to `Usize::Var` because it calls `builder.eval`.
builder.set_value(&domains, i, domain);
builder.assign(&domain_power, domain_power * g_dom);
Expand Down
2 changes: 1 addition & 1 deletion extensions/native/recursion/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ pub fn const_fri_config<C: Config>(
shift: C::F::ONE,
};
let domain_value: TwoAdicMultiplicativeCosetVariable<_> = builder.constant(constant_domain);
// FIXME: here must use `builder.set_value`. `builder.set` will convert `Usize::Const`
// ATTENTION: here must use `builder.set_value`. `builder.set` will convert `Usize::Const`
// to `Usize::Var` because it calls `builder.eval`.
builder.set_value(&subgroups, i, domain_value);
}
Expand Down

0 comments on commit fd19628

Please sign in to comment.