Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Do less conversion between u32 and F #1182

Merged
merged 1 commit into from
Jan 8, 2025
Merged

perf: Do less conversion between u32 and F #1182

merged 1 commit into from
Jan 8, 2025

Conversation

zlangley
Copy link
Contributor

@zlangley zlangley commented Jan 7, 2025

No description provided.

@zlangley zlangley marked this pull request as ready for review January 7, 2025 17:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-4 [-0.3%]) 1,431 195,158 8,027,972 - - -
fibonacci_program (-219 [-3.4%]) 6,235 1,500,137 51,505,102 - - -
regex_program (-128 [-0.6%]) 19,618 4,190,904 165,028,173 - - -
ecrecover_program (-8 [-0.3%]) 2,628 285,169 15,074,875 - - -

Commit: 1551844

Benchmark Workflow

jonathanpwang
jonathanpwang approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'm not sure if you wanted to merge this

@zlangley
Copy link
Contributor Author

zlangley commented Jan 8, 2025

lgtm, I'm not sure if you wanted to merge this

I don't see the harm; seems cleaner even if it makes negligible perf improvement.

@zlangley zlangley merged commit 5d7c7fc into main Jan 8, 2025
16 checks passed
@zlangley zlangley deleted the perf/defer-f branch January 8, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlangley @jonathanpwang