Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2E benchmark halo2 generate flamegraphs #1203

Merged
merged 12 commits into from
Jan 13, 2025

Conversation

stephenh-axiom-xyz
Copy link
Contributor

@stephenh-axiom-xyz stephenh-axiom-xyz commented Jan 10, 2025

Implements the following:

  • bench-metrics feature properly propagates to openvm-native-compiler module when set in the openvm-benchmarks and/or openvm-sdk modules.
  • SDK supports profiling for halo2 proof generation.
  • Flamegraph generation script a) generates halo2 flamegraphs and b) doesn't attempt to generate flamegraphs if the benchmark doesn't exist

Latest fib_e2e run results here (note fixed_cells is zero throughout and thus doesn't show up).

This comment has been minimized.

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a single flamegraph to consolidate lookup_advice_cells + simple_advice_cells? they should both be counted towards total cell count

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing comments

@yi-sun yi-sun force-pushed the feat/bench-halo2-flamegraph branch from c421044 to 383a4ce Compare January 12, 2025 06:29

This comment has been minimized.

@stephenh-axiom-xyz stephenh-axiom-xyz force-pushed the feat/bench-halo2-flamegraph branch from 383a4ce to f96b97e Compare January 13, 2025 04:46

This comment has been minimized.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+302 [+8.7%]) 3,777 (+34974 [+4.9%]) 746,301 (+4500079 [+17.6%]) 30,011,454 - - -
fibonacci_program (-19 [-0.3%]) 6,037 1,500,137 51,505,102 - - -
regex_program (-368 [-1.9%]) 18,563 4,190,904 165,028,173 - - -
ecrecover_program (+15 [+0.6%]) 2,617 285,401 15,092,297 - - -

Commit: ada40bd

Benchmark Workflow

@stephenh-axiom-xyz stephenh-axiom-xyz merged commit 0ea118f into main Jan 13, 2025
19 checks passed
@stephenh-axiom-xyz stephenh-axiom-xyz deleted the feat/bench-halo2-flamegraph branch January 13, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants