-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: E2E benchmark halo2 generate flamegraphs #1203
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make a single flamegraph to consolidate lookup_advice_cells + simple_advice_cells
? they should both be counted towards total cell count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing comments
c421044
to
383a4ce
Compare
This comment has been minimized.
This comment has been minimized.
383a4ce
to
f96b97e
Compare
This comment has been minimized.
This comment has been minimized.
Commit: ada40bd |
Implements the following:
bench-metrics
feature properly propagates toopenvm-native-compiler
module when set in theopenvm-benchmarks
and/oropenvm-sdk
modules.Latest
fib_e2e
run results here (notefixed_cells
is zero throughout and thus doesn't show up).