Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] use expr builder for modular chips #1212

Merged
merged 3 commits into from
Jan 15, 2025
Merged

[chore] use expr builder for modular chips #1212

merged 3 commits into from
Jan 15, 2025

Conversation

luffykai
Copy link
Contributor

@luffykai luffykai commented Jan 13, 2025

follow up from #1204

  • modular tests already call setup_all_moduli

@luffykai luffykai changed the title [chore] use expr builder for modular chips [chore] use expr builder for modular chips WIP Jan 13, 2025
@luffykai luffykai changed the title [chore] use expr builder for modular chips WIP [chore] use expr builder for modular chips Jan 13, 2025
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I approved this a while ago but lost internet.
LGTM and saves a nice amount of code.

Please fix lint

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-23 [-0.7%]) 3,494 711,211 25,510,215 - - -
fibonacci_program (-7 [-0.1%]) 6,078 1,500,137 51,505,102 - - -
regex_program 18,880 4,190,904 165,028,173 - - -
ecrecover_program (-114 [-4.3%]) 2,521 285,401 15,092,297 - - -

Commit: f3a25af

Benchmark Workflow

@luffykai luffykai merged commit 3fe3dc5 into main Jan 15, 2025
16 checks passed
@luffykai luffykai deleted the lunkai/mod-expr branch January 15, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants