-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Native Poseidon2 chip #1219
Merged
Merged
Changes from 47 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
522bbf9
Constraints for inside level
TlatoaniHJ ecd1129
Make optimizations to inside row constraints
TlatoaniHJ dc3a36e
Finish all constraints
TlatoaniHJ b6b1fb1
Make records and split out into files
TlatoaniHJ 81a6766
Some stuff
TlatoaniHJ 48ec9d9
Write row hash part of execute
TlatoaniHJ 9a8a480
Finish execute and add opcode
TlatoaniHJ c631312
Fill in interaction
TlatoaniHJ 92b29d8
Finish (almost) trace generation for incorporate sibling
TlatoaniHJ dfd5073
Commit some stuff
TlatoaniHJ 6e53d2f
Finish top level trace generation
TlatoaniHJ 1c8c29d
Finish trace generation for inside row
TlatoaniHJ 4c84f49
Finish implementation
TlatoaniHJ 0353599
Implement verify_batch for test
TlatoaniHJ 6fac595
Write test (only positive for now)
TlatoaniHJ 78ba3f6
Some cleanup
TlatoaniHJ e15f8a8
Fix handling of initial cell
TlatoaniHJ 851a8bd
Get execute and trace generation working
TlatoaniHJ 582735d
Fix some bugs causing interaction to be unbalanced
TlatoaniHJ 65467c6
Fix constraints
TlatoaniHJ 97b17c6
Test passing
TlatoaniHJ 648ee8d
Remove debugging statements
TlatoaniHJ 235eea4
Cleanup
TlatoaniHJ ffb6286
Add negative test
TlatoaniHJ 7866767
Add a test with multiple operations (failing)
TlatoaniHJ 2a052eb
Fix failing test
TlatoaniHJ 38cd631
Add compiler stuff
TlatoaniHJ 02feb4f
Make fibonacci_small pass (without ext verify_batch)
TlatoaniHJ d2b0942
Remove debugging statements
TlatoaniHJ 657c80d
Make address space constant
TlatoaniHJ 04b6192
Get varying open value size working for felt
TlatoaniHJ d1a43e7
Fully integrate
TlatoaniHJ bfacc6a
Merge branch 'main' into feat/native-p2-chip
TlatoaniHJ 823deea
Fix merge main
TlatoaniHJ 2e0db3e
Fix magical test
TlatoaniHJ d924444
Fix behavior for rolling_hash not multiple of 8
TlatoaniHJ 6fb7d15
Optimize specific columns
TlatoaniHJ 7a0ee20
Passing old p2 tests
TlatoaniHJ 8f8d335
Add simple perm functionality
TlatoaniHJ 87ec833
Support COMP_POS2
TlatoaniHJ 8069c0c
Merge branch 'main' into feat/native-p2-chip
TlatoaniHJ 2c70598
Remove old Poseidon2 chip
TlatoaniHJ ae3a551
Fix magical test
TlatoaniHJ a724e49
Fix lint
TlatoaniHJ c247440
Document VERIFY_BATCH opcode
TlatoaniHJ 5482566
Rename VerifyBatchChip to NativePoseidon2Chip
TlatoaniHJ 76def78
Rustfmt
TlatoaniHJ 57c4d8f
merge
yi-sun 522734e
chore: move poseidon2 opcode and test into native-compiler/circuit
jonathanpwang 9b0b7f4
chore: add some comments
jonathanpwang dd0fa74
chore: remove magic bus idx 7
jonathanpwang 3f64254
nit: cleanup std::array::
jonathanpwang 3c5c4a3
chore: update stark-backend rev
jonathanpwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This explanation is probably not going to be that helpful, if we could point to a rust function or a more detailed writeup, that would be better.