Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bigint extern functions were not updated on macro usage #1222

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jonathanpwang
Copy link
Contributor

@arayikhalatyan can you help add some unit tests for extern functions in this repo for the future?

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+30 [+0.9%]) 3,542 711,284 25,510,945 - - -
fibonacci_program (+10 [+0.2%]) 6,113 1,500,137 51,505,102 - - -
regex_program (+69 [+0.4%]) 18,980 4,190,904 165,028,173 - - -
ecrecover_program (-11 [-0.4%]) 2,605 285,401 15,092,297 - - -

Commit: 3ab937e

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 1ad4140 into main Jan 16, 2025
16 checks passed
@jonathanpwang jonathanpwang deleted the fix/bigint-extern branch January 16, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant