Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WeierstrassConfig zip moduli #1227

Merged
merged 5 commits into from
Jan 17, 2025
Merged

fix: WeierstrassConfig zip moduli #1227

merged 5 commits into from
Jan 17, 2025

Conversation

jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Jan 17, 2025

WeierstrassConfig (only used for testing) auto creates the moduli. It is more natural to do coordinate,scalar per curve instead of doing all coordinate first.

This comment has been minimized.

@jonathanpwang jonathanpwang changed the title bug: failing test with two curves fix: WeierstrassConfig zip moduli Jan 17, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@jonathanpwang
Copy link
Contributor Author

@luffykai this one is fixed, can you take a look and then merge

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+76 [+2.2%]) 3,576 711,523 25,513,335 - - -
fibonacci_program (-107 [-1.7%]) 6,031 1,500,137 51,505,102 - - -
regex_program (-35 [-0.2%]) 18,887 4,190,904 165,028,173 - - -
ecrecover_program (+18 [+0.7%]) 2,627 285,401 15,092,297 - - -

Commit: c964d4d

Benchmark Workflow

@luffykai luffykai merged commit fc90b5d into main Jan 17, 2025
16 checks passed
@luffykai luffykai deleted the fix/ec_double branch January 17, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants