Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Optimize Static Verifier alpha pow computation #1250

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[chore] Optimize Static Verifier alpha pow computation #1250

merged 1 commit into from
Jan 23, 2025

Conversation

nyunyunyunyu
Copy link
Contributor

@nyunyunyunyu nyunyunyunyu commented Jan 22, 2025 •
edited by yi-sun
Loading

Closes INT-3077

@nyunyunyunyu nyunyunyunyu added run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e labels Jan 22, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-21 [-0.9%]) 2,275 513,747 19,385,753 - - -
fibonacci_program (+18 [+0.3%]) 6,043 1,500,137 51,487,838 (-21 [-0.3%]) 7,858 1,833,699 75,487,217
regex_program (-251 [-1.4%]) 17,612 4,190,904 165,010,909 (-158 [-0.8%]) 19,034 3,028,767 163,286,081
fib_e2e 41,240 12,000,137 410,699,582 55,944 11,459,838 461,457,929
ecrecover_program (+9 [+0.3%]) 2,604 285,401 15,075,033 (-205 [-0.9%]) 22,397 4,166,623 241,409,329

Commit: 765f1a7

Benchmark Workflow

@nyunyunyunyu nyunyunyunyu marked this pull request as ready for review January 23, 2025 01:16
@nyunyunyunyu nyunyunyunyu requested a review from yi-sun January 23, 2025 01:16
yi-sun
yi-sun approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@yi-sun yi-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yi-sun yi-sun merged commit 3886067 into main Jan 23, 2025
26 checks passed
@yi-sun yi-sun deleted the chore/manual-reduce branch January 23, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yi-sun yi-sun yi-sun approved these changes

Assignees
No one assigned
Labels
run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyunyunyunyu @yi-sun