Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] support custom segmentation #1254

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[feat] support custom segmentation #1254

merged 2 commits into from
Jan 23, 2025

Conversation

luffykai
Copy link
Contributor

redo #1245

fix INT-3005

@luffykai luffykai mentioned this pull request Jan 22, 2025
Closed
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
jonathanpwang
jonathanpwang reviewed Jan 23, 2025
View reviewed changes
crates/vm/src/arch/segment.rs
fn should_segment(
&self,
air_names: &[String],
trace_heights: &[usize],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just pass in all of chip_complex? that seems more flexible - but maybe there's an issue with VC generic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I don't know if possible to do generic in that trait to work with the Arc<dyn>
#1245 (comment)

jonathanpwang
jonathanpwang approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some comments. Much cleaner than the other PR!

@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+48 [+2.1%]) 2,296 513,757 19,385,853 - - -
fibonacci_program (+77 [+1.3%]) 6,148 1,500,137 51,487,838 - - -
regex_program (-136 [-0.7%]) 18,388 4,190,904 165,010,909 - - -
ecrecover_program (-38 [-1.5%]) 2,573 285,401 15,075,033 - - -

Commit: 89f876e

Benchmark Workflow

@luffykai luffykai merged commit 21ebf2b into main Jan 23, 2025
22 checks passed
@luffykai luffykai deleted the lunkai/custom-seg2 branch January 23, 2025 16:43
This was referenced Jan 23, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@nyunyunyunyu nyunyunyunyu Awaiting requested review from nyunyunyunyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luffykai @jonathanpwang