Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove AffineCoords trait #1265

Merged
merged 2 commits into from
Jan 23, 2025
Merged

chore: Remove AffineCoords trait #1265

merged 2 commits into from
Jan 23, 2025

Conversation

ytham
Copy link
Contributor

@ytham ytham commented Jan 23, 2025

  • Remove AffineCoords trait
  • Update tests to use G1Affine and G2Affine directly

@jonathanpwang
Copy link
Contributor

fix lint

jonathanpwang
jonathanpwang approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+26 [+1.1%]) 2,367 513,309 19,357,682 - - -
fibonacci_program (-24 [-0.4%]) 6,057 1,500,137 51,487,838 - - -
regex_program (-632 [-3.4%]) 17,756 4,190,904 165,010,909 - - -
ecrecover_program (-3 [-0.1%]) 2,585 285,401 15,075,033 - - -

Commit: f2cbeda

Benchmark Workflow

@ytham ytham merged commit 4cef5a9 into main Jan 23, 2025
16 checks passed
@ytham ytham deleted the chore/remove_affine_coords_trait branch January 23, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ytham @jonathanpwang