Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to inner product #1280

Merged
merged 5 commits into from
Jan 26, 2025
Merged

change to inner product #1280

merged 5 commits into from
Jan 26, 2025

Conversation

MonkeyKing-1
Copy link
Contributor

Babybear now uses gate.inner_product() to save on a few cells for ext multiply (which is called a lot). Seems to give 10% decrease in cells for this test: halo2::tests::stark::test_fibonacci

This comment has been minimized.

This comment has been minimized.

@MonkeyKing-1 MonkeyKing-1 marked this pull request as ready for review January 24, 2025 22:44

This comment has been minimized.

@jonathanpwang jonathanpwang merged commit 352ca42 into main Jan 26, 2025
18 checks passed
@jonathanpwang jonathanpwang deleted the feat/babybear_inner_prod branch January 26, 2025 01:55
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+133 [+5.9%]) 2,391 513,713 19,375,651 - - -
fibonacci_program (+630 [+11.5%]) 6,116 1,500,137 51,487,838 - - -
regex_program (+1589 [+9.3%]) 18,741 4,190,904 165,010,909 - - -
fib_e2e 41,617 12,000,137 410,699,582 54,219 11,453,453 437,454,205
ecrecover_program (+122 [+4.9%]) 2,618 285,401 15,075,033 - - -

Commit: 11f9a1d

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants