chore: update docs #1291
Merged
chore: update docs #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yi-sun
force-pushed
the
chore/update-docs
branch
2 times, most recently
from
c1a5d73 to
b9dd453
Compare
yi-sun
force-pushed
the
chore/update-docs
branch
from
012cd8e to
54f11a5
Compare
yi-sun
commented
Jan 26, 2025
yi-sun
force-pushed
the
chore/update-docs
branch
from
1133ec1 to
ed8603d
Compare
yi-sun
commented
Jan 26, 2025
| | subcomplex | R | 0101011 | 010 | `idx*8+1` | Read `x: Fp2` from `[rs1..]_2` and `y: Fp2` from `[rs2..]_2`. Write `x - y` to `[rd..]_2` | | ||
| | mulcomplex | R | 0101011 | 010 | `idx*8+2` | Read `x: Fp2` from `[rs1..]_2` and `y: Fp2` from `[rs2..]_2`. Write `x * y` to `[rd..]_2` | | ||
| | divcomplex | R | 0101011 | 010 | `idx*8+3` | Read `x: Fp2` from `[rs1..]_2` and `y: Fp2` from `[rs2..]_2`. Write `x / y` to `[rd..]_2` | | ||
| | setupcomplex| R | 0101011 | 010 | `idx*8+4` | `assert([rs1: Fp::NUM_LIMBS]_2 == Fp::MODULUS)` in the chip defined by the register index of `rs2`. For the sake of implementation convenience it also writes something (can be anything) into `[rd: Fp::NUM_LIMBS]_2`. | |
There was a problem hiding this comment.
@Golovanov399 -- can you check correctness here?
jonathanpwang
approved these changes
Jan 26, 2025
Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
yi-sun
force-pushed
the
chore/update-docs
branch
from
02a48b4 to
46ab366
Compare
jonathanpwang
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes INT-2938, INT-3109, INT-3123