fix: alignment in unsafe rust #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jonathanpwang
force-pushed
the
fix/unsafe-alignment
branch
from
80b1789 to
92d0bba
Compare
Commit: 92d0bba |
| } else { | ||
| panic!("limbs must be at most 48"); | ||
| } | ||
|
|
||
| let block_size = proc_macro::Literal::usize_unsuffixed(block_size); |
There was a problem hiding this comment.
oh wow good to know this exists
There was a problem hiding this comment.
wait, I copied this from code you wrote!
There was a problem hiding this comment.
Hmm I thought I used some hacks for this, but maybe this was the hack...
Golovanov399
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust treats
[u8; LEN]as having alignment of1, so if you unsafely transmute or convert a slice to[T; LEN]which expects alignment ofalign_of<T>(), then this may result in misaligned load/store instructions, often during operations like memcpy. OpenVM RV32 does not support misaligned access (see #1474), so we make sure all our use of unsafe Rust has proper alignment.