Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Constrain initial timestamp in connector chip #1495

Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix: Constrain initial timestamp in connector chip #1495

merged 1 commit into from
Mar 20, 2025

Conversation

zlangley
Copy link
Contributor

No description provided.

@zlangley zlangley force-pushed the fix/connector-initial-timestamp branch from b5f8f42 to f1dc883 Compare March 20, 2025 16:28
@zlangley zlangley mentioned this pull request Mar 20, 2025
Merged
@zlangley zlangley force-pushed the fix/connector-initial-timestamp branch from f1dc883 to 408efa1 Compare March 20, 2025 16:36
@zlangley zlangley force-pushed the fix/connector-initial-timestamp branch from 408efa1 to de5732b Compare March 20, 2025 16:40
zlangley
zlangley commented Mar 20, 2025
View reviewed changes
crates/vm/src/system/connector/mod.rs
@@ -145,6 +145,8 @@ impl<AB: InteractionBuilder + PairBuilder + AirBuilderWithPublicValues> Air<AB>
.when_transition()
.assert_eq(end.is_terminate, is_terminate);

builder.when_transition().assert_one(begin.timestamp);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could of course instead just send 1 in the interaction below, but I think this is clearer.
(Otherwise timestamp on first row would be unconstrained and potentially confusing.)

@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-22 [-1.8%]) 1,229 334,044 17,902,600 - - -
fibonacci_program (+6 [+0.2%]) 2,675 1,500,096 51,485,167 - - -
regex_program (-50 [-0.6%]) 7,733 4,140,229 167,420,929 - - -
ecrecover_program (-9 [-0.6%]) 1,432 295,285 15,597,969 - - -
pairing (-18 [-0.4%]) 4,714 1,711,640 92,620,923 - - -

Commit: de5732b

Benchmark Workflow

@zlangley zlangley changed the title fix: Constrain initial timestamp to 0 in connector chip fix: Constrain initial timestamp in connector chip Mar 20, 2025
@jonathanpwang jonathanpwang merged commit c136e57 into main Mar 20, 2025
23 checks passed
@jonathanpwang jonathanpwang deleted the fix/connector-initial-timestamp branch March 20, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@Golovanov399 Golovanov399 Awaiting requested review from Golovanov399

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlangley @jonathanpwang