Add integration test for interactions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyunyunyunyu
force-pushed
the
test/add-interaction-test
branch
from
56c84c0 to
6a1905f
Compare
| trace_data: &proven_trace, | ||
| airs: airs | ||
| .iter() | ||
| .map(|&air| air as &dyn ProverRap<StarkConfigPoseidon2>) |
jonathanpwang
approved these changes
May 13, 2024
shuklaayush
reviewed
May 13, 2024
| use p3_field::Field; | ||
| use p3_matrix::dense::RowMajorMatrix; | ||
|
|
||
| pub struct DummyInteractionAir { |
There was a problem hiding this comment.
Side note: this is general enough that we should move it into the sdk once it exists, as a general chip testing util
There was a problem hiding this comment.
Keep it here for now. Other tests can still use it.
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Add integration test for interactions * Add more test cases * Readability improvement
Avaneesh-axiom
pushed a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nightly-2024-05-01fromstableto use an experimental feature(upcasting).DummyInteractionAirintestsfor testing.EqforVerificationErrorto make testing easier.