feat: GKR LogUp #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +66,7 @@ where | |||
| type PartialProof = (); | |||
| type ProvingKey = StarkLogUpProvingKey; | |||
There was a problem hiding this comment.
do we still need this? I'm not sure if philosophically RAP phase should every require more information than the rest of the proving key provides
There was a problem hiding this comment.
nvm FRI logup does require it in the permutation trace generation. hmm it's kind of weird
There was a problem hiding this comment.
This is actually only needed for FRI logug because FRI log up needs interaction chunk size (and GKR log up doesn't). GKR doesn't currently have any proving parameters.
zlangley
force-pushed
the
gkr-logup
branch
7 times, most recently
from
e517748 to
63df013
Compare
zlangley
force-pushed
the
gkr-logup
branch
4 times, most recently
from
d7d7eed to
0d51a2f
Compare
kunxian-xia
added a commit
that referenced
this pull request
Jan 26, 2025
* use p3-gpu * use self-hosted ci runner * use https instead of git url * use github secret to fetch plonky3-gpu * Revert "use https instead of git url" This reverts commit 0b3343f3ece9b920644553e7e6101106ee620351. * set CARGO_NET_GIT_FETCH_WITH_CLI * Revert "set CARGO_NET_GIT_FETCH_WITH_CLI" This reverts commit 7973118c3c221ffb7637750df641631f4562b6c0. * add sppark deploy key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.