Extra features setup json #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeroenmaelbrancke
commented
Feb 2, 2018
jeroenmaelbrancke
commented
- mds_safety
- volumedriver config
JeffreyDevloo
suggested changes
Feb 2, 2018
helpers/storagedriver.py
Outdated
| import json | ||
|
|
||
| try: | ||
| from ovs.extensions.services.service import ServiceManager |
There was a problem hiding this comment.
The current master branch points towards FWK 2.11
No need to have this try-except stuff
setup/vpool.py
Outdated
|
|
||
| # Settings volumedriver | ||
| storagedriver_config = {} | ||
| if vpool_details.get('storagedriver').get('volume_manager') is not None: |
There was a problem hiding this comment.
If storagedriver would be filled in, I'd opt to validate the possible options (see how we validate the call params)
So something like:
storagedriver_config = vpool_details.get('storagedriver')
if storagedriver_config (not None or empty dict) -> validate this item before proceeding
|
@JeffreyDevloo can review my changes? |
JeffreyDevloo
approved these changes
Feb 6, 2018
JeffreyDevloo
pushed a commit
that referenced
this pull request
Feb 7, 2018
Extra features setup json (cherry picked from commit 0f6561f) # Conflicts: # helpers/storagedriver.py # setup/vpool.py
JeffreyDevloo
added a commit
that referenced
this pull request
Feb 7, 2018
Merge pull request #73 from openvstorage/extra_features_setup_json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.