Tezos-opencl: Workaround for buggy nvidia driver #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solardiz
approved these changes
Nov 2, 2024
solardiz
reviewed
Nov 2, 2024
| @@ -121,6 +121,9 @@ ge25519_scalarmult_base_choose_niels(ge25519_niels *t, uint32_t pos, signed char | |||
|
|
|||
| /* computes [s]basepoint */ | |||
| static void | |||
| #if gpu_nvidia(DEVICE_INFO) && DEV_VER_MAJOR > 500 | |||
There was a problem hiding this comment.
The strict > 500 is a bit weird, meaning 501 or higher. Perhaps you meant >= 500.
There was a problem hiding this comment.
I think I had it working with 525.xx so maybe we should use that. Also I now confirmed the 560 or higher CUDA drivers work fine without the noinline, which is great! I'll amend it.
magnumripper
force-pushed
the
tezos-nvidia-fix
branch
from
dbdac10
to
05eda99
Compare
solardiz
reviewed
Nov 2, 2024
| @@ -121,6 +121,9 @@ ge25519_scalarmult_base_choose_niels(ge25519_niels *t, uint32_t pos, signed char | |||
|
|
|||
| /* computes [s]basepoint */ | |||
| static void | |||
| #if gpu_nvidia(DEVICE_INFO) && DEV_VER_MAJOR > 525 && DEV_VER_MAJOR < 560 | |||
There was a problem hiding this comment.
Again, you probably mean >= 525, not > 525.
There was a problem hiding this comment.
Oh, I see you wrote you saw the issue with 535 and 550. But apparently not with 525, nor 560. If so, the check is right.
There was a problem hiding this comment.
Generic, but very appropriate to the situation: it's documenting that anything after 525 and before 560 is or could be bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5546