Align IssuerMetadata with VCI 1.0 spec #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r support Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
…-framework-dotnet into algin-isser-metadata-with-oid4vci1.0 Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
…-framework-dotnet into algin-isser-metadata-with-oid4vci1.0 Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Dindexx
requested changes
Oct 29, 2025
| select path; | ||
| } | ||
|
|
||
| public static JArray ToArray(ClaimPath claimPath) |
| array.Add(new JValue(index)); | ||
| return Unit.Default; | ||
| }, | ||
| selectAll => |
Contributor
There was a problem hiding this comment.
value selectAll is never used
|
|
||
| public static class ClaimPathFun | ||
| { | ||
| public static JsonPath ToJsonPath(this ClaimPath claimPath) |
|
|
||
| namespace WalletFramework.Oid4Vc.Oid4Vci.CredConfiguration.Models; | ||
|
|
||
| public record ClaimDisplay |
Contributor
There was a problem hiding this comment.
Delete the other legacy ClaimDisplays
|
|
||
| public record ClaimDisplay | ||
| { | ||
| public Option<string> Name { get; set; } |
| { | ||
| public Option<string> Name { get; set; } | ||
|
|
||
| public Option<Locale> Locale { get; set; } |
|
|
||
| namespace WalletFramework.Oid4Vc.Oid4Vci.CredConfiguration.Models; | ||
|
|
||
| public record ClaimDisplay |
Contributor
There was a problem hiding this comment.
Is it possible to have a name without a locale ? Otherwise, a name must be mapped by a locale and this is not reflected here
Contributor
Author
There was a problem hiding this comment.
Yes, according to the specs a name can exist without a locale. https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#appendix-B.2-2.3.1
| } | ||
|
|
||
| [Fact] | ||
| public void Can_Decode_And_Encode_From_Json_Draft14() |
| } | ||
| }; | ||
|
|
||
| public static JObject EncodedAsJsonDraft15 => new() |
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves: