Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial commit - Webvh #1377

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Jan 9, 2025

WIP - Adds basic did create/update/deactivate support with the didwebvh-server-py project.

Includes endorsement protocol, initial integration testing and some initial unit tests.

webvh/webvh/routes.py Outdated Show resolved Hide resolved
webvh/webvh/did/manager.py Outdated Show resolved Hide resolved
webvh/webvh/did/manager.py Outdated Show resolved Hide resolved
webvh/webvh/did/manager.py Outdated Show resolved Hide resolved
@jamshale
Copy link
Contributor Author

Update/Deactivate have some old implementation still but aren't finished. Prerotation is also not implemented atm.

Integration test will fail until the server changes are merged to main.

Endorsement requires the endorser agent creating a key with a kid that equals the server url. Then the server needs the verify the public key. Currently the integration tests use insecure seed to automate this set up.

@jamshale
Copy link
Contributor Author

Integration test is failing because it's not using an https domain. Thinking about how to get around this with the base library.

Also, currently the ssl checks in the plugin are turned off. I'll need to update that.

Copy link

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review/comments

webvh/webvh/did/operations_manager.py Outdated Show resolved Hide resolved
webvh/webvh/did/operations_manager.py Show resolved Hide resolved
webvh/webvh/did/operations_manager.py Outdated Show resolved Hide resolved
webvh/webvh/did/operations_manager.py Outdated Show resolved Hide resolved
webvh/webvh/did/operations_manager.py Outdated Show resolved Hide resolved
webvh/webvh/did/tests/test_endorsement_namager.py Outdated Show resolved Hide resolved
webvh/webvh/did/utils.py Outdated Show resolved Hide resolved
webvh/webvh/routes.py Show resolved Hide resolved
@jamshale
Copy link
Contributor Author

The integration test for auto endorsing isn't working even though it's working manually. The test still allows the initial log to get posted so I removed the assertion for now.

webvh/webvh/did/utils.py Outdated Show resolved Hide resolved
webvh/webvh/did/utils.py Outdated Show resolved Hide resolved
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants