Set Pending state on Deep Link action #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
loneil
commented
May 14, 2024
loneil
commented
May 14, 2024
Comment on lines
389
to
390
| deepLinkOpen() { | ||
| state.disableDeeplink = true; | ||
| this.setUiStates("pending"); |
There was a problem hiding this comment.
Set Deep Link pending status
loneil
commented
May 14, 2024
Comment on lines
400
to
411
| setUiStates(status) { | ||
| state.current = status; | ||
| state.showSpinner = status === "pending"; | ||
| state.showScanned = ["pending", "verified"].includes(status); | ||
| state.showRefresh = ["abandoned", "expired", "failed"].includes( | ||
| status | ||
| ); | ||
| state.disableDeeplink = [ | ||
| "abandoned", | ||
| "expired", | ||
| "pending", | ||
| "success", | ||
| ].includes(status); |
There was a problem hiding this comment.
Refactor to be called from multiple spots
loneil
commented
May 14, 2024
| }); | ||
| this.socket.on("status", (data) => { | ||
| console.log("Toggling state", data.status); | ||
| this.setUiStates(data.status); |
There was a problem hiding this comment.
Refactor to be called from multiple spots
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com> tweak Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
loneil
force-pushed
the
bugfix/deepLinkDisable
branch
from
a956ba7 to
64c3fbf
Compare
esune
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Deep Link when clicked was opening the pres req on the BC Wallet but leaving the button enabled. This can cause the issue discussed here
bcgov/bc-wallet-mobile#1956 (comment)
Change it to set the deep link button to disabled (Pending status triggered manually, since it's not updating on the server when deep link is used, no callback)
See comments for relevant changes in html file, diff is big because there was a extraneous div ending that was breaking prettier so I fixed that and formatted.