Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy log when webhook cannot be delivered #3126

Closed
esune opened this issue Jul 25, 2024 · 0 comments · Fixed by #3170
Closed

Noisy log when webhook cannot be delivered #3126

esune opened this issue Jul 25, 2024 · 0 comments · Fixed by #3170
Assignees

Comments

@esune
Copy link
Member

esune commented Jul 25, 2024

When an agent is set-up to deliver webhooks to one (or more) endpoints, it will throw an exception and print a full stack trace error if the endpoint cannot be resolved/contacted.

Example:

2024-07-23 21:55:11,754 aries_cloudagent.transport.outbound.manager ERROR Outbound message could not be delivered to http://my-controller-url.example/topic/present_proof/
Traceback (most recent call last):
File "/usr/local/lib/python3.9/asyncio/tasks.py", line 256, in __step
result = coro.send(None)
File "/home/aries/.venv/lib/python3.9/site-packages/aries_cloudagent/transport/outbound/http.py", line 84, in handle_message
raise OutboundTransportError(
aries_cloudagent.transport.outbound.base.OutboundTransportError: Unexpected response status 404, caused by: NOT FOUND

This does not prevent the agent from continuing its operation correctly, a better behaviour would be to log a WARNING statement without a stack trace.

@esune esune moved this to Assignment Ready in CDT Enterprise Apps Jul 25, 2024
@jamshale jamshale self-assigned this Aug 15, 2024
@jamshale jamshale linked a pull request Aug 15, 2024 that will close this issue
@esune esune moved this from Assignment Ready to Assigned in CDT Enterprise Apps Aug 20, 2024
@github-project-automation github-project-automation bot moved this from Assigned to Complete in CDT Enterprise Apps Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants