Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ POST v1.0.0 ] Adjust message queue error handling #3170

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

jamshale
Copy link
Contributor

This changes log levels for messages that get retried and for webhook specific errors.

  • The re-queued messages won't be logged anymore except at debug level. I think this is appropriate because the message hasn't actually failed at this point.
  • For webhook specific fails. Discovered by /webhook/topic being in the endpoint, the log level will be warning. For all other failed messages the log level will remain exception level.

Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale linked an issue Aug 15, 2024 that may be closed by this pull request
@jamshale jamshale enabled auto-merge (squash) August 20, 2024 18:12
@jamshale jamshale merged commit 96e8315 into openwallet-foundation:main Aug 20, 2024
7 checks passed
Copy link

sonarcloud bot commented Aug 20, 2024

jamshale added a commit to jamshale/acapy that referenced this pull request Aug 22, 2024
Signed-off-by: jamshale <jamiehalebc@gmail.com>
darshilnb pushed a commit to Northern-Block/aries-cloudagent-python that referenced this pull request Sep 5, 2024
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noisy log when webhook cannot be delivered
2 participants