Fix: stateless record webhooks #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error on the side of caution for BaseRecord.emit_event, using topic without state when none is given, and inserting the serialized record as the payload if no payload is given. Events are only not emitted by records when no record topic is set. Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Should now accept stateless record event topics Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
TimoGlastra
previously approved these changes
Apr 28, 2021
| @@ -1,7 +1,9 @@ | |||
| from aries_cloudagent.core.event_bus import Event | |||
There was a problem hiding this comment.
Auto-import failed me 🙂 fixed
Codecov Report
@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
+ Coverage 99.19% 99.20% +0.01%
==========================================
Files 383 383
Lines 22133 22139 +6
==========================================
+ Hits 21954 21964 +10
+ Misses 179 175 -4 |
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
ianco
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully address #1123.
Changes
fix: stateless records emit events
Error on the side of caution for BaseRecord.emit_event, using topic
without state when none is given, and inserting the serialized record as
the payload if no payload is given.
Events are only not emitted by records when no record topic is set.
fix: relax admin server record event pattern
Should now accept stateless record event topics
fix: add event namespace to base records to allow plugins to override
test: record topic parsing for webhook